You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The existing logic of the if statement that generated the error message "Optional first arg is not a POINT_PROCESS" was incorrect.
[ ] add test
[ ] update documentation
The Vector.record also presently requires the existence of a Section. This seems unnecessary if the POINT_PROCESS or ARTIFICIAL_CELL arg is present. Section could disagree with POINT_PROCESS about which thread they are in.
It is not easy for the user to determine the thread of an ARTIFICIAL_CELL. Perhaps there should be a method for ARTIFICIAL_CELL and POINT_PROCESS which returns the thread id. Also, recording thread time and associating with a range variable is not obvious to the user. Finally, Vector.record(callable) could be useful.
In most cases, i.e. all range variables, aren't the POINT_PROCESS or Section hints unnecessary? Because the reference argument is a DataHandle. The hint is only needed when a reference, e.g. h._ref_t is not associated with (the desired) thread or cvode instance.
❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.07%. Comparing base (c18450a) to head (2a96b68). ⚠️ Report is 1181 commits behind head on master.
The CI was previously green here. I have re-launched CI on this branch just to see if the issue with recent latest failures is code related or runners environment. cc: @alkino
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing logic of the
ifstatement that generated the error message"Optional first arg is not a POINT_PROCESS"was incorrect.[ ] add test
[ ] update documentation
The Vector.record also presently requires the existence of a Section. This seems unnecessary if the POINT_PROCESS or ARTIFICIAL_CELL arg is present. Section could disagree with POINT_PROCESS about which thread they are in.
It is not easy for the user to determine the thread of an ARTIFICIAL_CELL. Perhaps there should be a method for ARTIFICIAL_CELL and POINT_PROCESS which returns the thread id. Also, recording thread time and associating with a range variable is not obvious to the user. Finally, Vector.record(callable) could be useful.
In most cases, i.e. all range variables, aren't the POINT_PROCESS or Section hints unnecessary? Because the reference argument is a DataHandle. The hint is only needed when a reference, e.g.
h._ref_tis not associated with (the desired) thread or cvode instance.